Re: Cyrus IMAP pre-login buffer overrun

["Renaud Deraison" <deraison_at_nessus.org>]

On Fri, Dec 20, 2002 at 11:35:10AM +0000, Paul Johnston wrote:
> 1) Is there a proper mechanism for allocating script IDs?

No. I do allocate them when I commit them in the CVS tree.

> 2) What's the best way to use the script_version() line?

Leave it to "$Revision$". CVS handles the rest.

> 3) When I do this:
> 
> key = string("imap/banner/", port);
[...]
> 
> Is it right to be saving the banner back into the knowledge base? 
> Logically I'd think it is, but other scripts don't seem to do this.

It should be right, however find_service is supposed to do that already.
The reason why I don't like to register banners this way is that there
is a chance two scripts run at the same time and register the same info.

Given the current design, so could eventually slow down the rest of the
imap checks, so I'd prefer to let find_services do it.



				-- Renaud